Implement new ip filter config & portal UI #5485
Conversation
because this screen does not exist
tung2744
changed the title
carmenlau
left a comment
carmenlau
left a comment
There was a problem hiding this comment.
When clicking Check with an invalid IP address, the error message isn’t handled.
| "country_codes": { | ||
| "geo_location_codes": { | ||
| "type": "array", | ||
| "items": { "type": "string" } |
There was a problem hiding this comment.
We should keep the restriction that only allows two-character country codes
| return defaultAction | ||
| } | ||
|
|
||
| func (m *IPFilterMiddleware) isRuleMatched(remoteIP net.IP, remoteIPStr string, rule *config.IPFilterRule) bool { |
There was a problem hiding this comment.
I think it would be better for the middleware and the portal checkIP mutation to use the same implementation, so we can ensure they produce the same results even if we update the logic in the future. Otherwise, it’s easy to miss updating the portal when changes are made here.
Thought?
| appConfigChecksum: rawAppConfigChecksum, | ||
| ignoreConflict: ignoreConflict, | ||
| }); | ||
| await reload(); |
There was a problem hiding this comment.
Fix app config form will show incorrect state for a while after save
I'd like to know how can I trigger this?
| "IPBlocklistScreen.description": "Block traffic by IP address or geographic region to prevent unwanted access and reduce automated threats.", | ||
| "IPBlocklistForm.enable.label": "Enable IP Blocklist", | ||
| "IPBlocklistForm.ip-address.label": "Blocked IP Addresses", | ||
| "IPBlocklistForm.ip-address.description": "Enter a comma-separated list of IP addresses to block. IPv4, IPv6, and CIDR notation for ranges are supported.", |
There was a problem hiding this comment.
Should update the copywriting to use newline instead
2 participants
ref DEV-3293
ref DEV-3297
Screen.Recording.2025-12-23.at.3.01.59.PM.mov