Add a temporary token for admin api page for testing #5484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmenlau
changed the title
carmenlau
force-pushed
the
dev-3252-portal-admin-api-temp-token
branch
from
87c9c3d to
8ddf3f7
Compare
tung2744
reviewed
Dec 23, 2025
pkg/portal/graphql/token_mutation.go
Outdated
| } | ||
|
|
||
| if len(secretConfig.AdminAPISecrets) == 0 { | ||
| return nil, apierrors.NewInvalid("no admin API auth key found") |
Contributor
There was a problem hiding this comment.
I think this can be a internal error, because project should have at least one key.
tung2744
reviewed
Dec 23, 2025
Comment on lines
222
to
224
| generateShortLivedAdminAPITokenHandle().catch(() => { | ||
| reauthentication(); | ||
| }); |
Contributor
There was a problem hiding this comment.
Can we check the actual error thrown, and only call reauthentication if the error is related?
I think there might be other errors which we want to log an error and probably display error ui to user. e.g. Network error or server error.
carmenlau
force-pushed
the
dev-3252-portal-admin-api-temp-token
branch
from
8ddf3f7 to
1ac36cc
Compare
Contributor
Author
|
Updated, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref DEV-3252
The implementation is a bit different from the design