Skip to content

feat: Add warning when insecure algorithm is used. #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2020

Conversation

gkwang
Copy link
Contributor

@gkwang gkwang commented Mar 24, 2020

Description

The warning is piped to stderr using console.warn().
Added option to turn it off; defaults to true.

#66

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

The warning is piped to stderr using console.warn().
Added option to turn it off; defaults to true.
@gkwang gkwang requested a review from a team as a code owner March 24, 2020 00:21
@gkwang gkwang added this to the v1.1.0 milestone Mar 25, 2020
@gkwang gkwang merged commit 25d22fd into auth0:master Mar 25, 2020
@markstos
Copy link

For those looking to upgrade to this with only warnings enable, the option that needs to be set is:

 disallowDecryptionWithInsecureAlgorithm: false,

That will continue to allow the insecure algorithms. The warnings are enabled by default and require no flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants