Upgrade: jwa dependency from 1.1.5 -> 1.1.6#80
Closed
andygout wants to merge 1 commit intoauth0:masterfrom
Financial-Times:upgrade-jwa-dependency
Closed
Upgrade: jwa dependency from 1.1.5 -> 1.1.6#80andygout wants to merge 1 commit intoauth0:masterfrom Financial-Times:upgrade-jwa-dependency
andygout wants to merge 1 commit intoauth0:masterfrom
Financial-Times:upgrade-jwa-dependency
Conversation
|
@omsmith @brianloveswords we are failing |
|
Can we have this merged? Node security is bugging us for |
tperamaki
approved these changes
Jan 2, 2019
tperamaki
left a comment
There was a problem hiding this comment.
@brianloveswords I approved this PR, now you can merge it 😃
omsmith
pushed a commit
that referenced
this pull request
Jan 25, 2019
omsmith
pushed a commit
that referenced
this pull request
Jan 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades the
jwadependency from^1.1.5to^1.1.6so that projects not downloading packages on a semver basis (i.e. using apackage-lock.json) are able to benefit from the changes introduced in v1.1.6 of that package, namely:base64url.ecdsa-sig-formatterfrom v1.0.9 to v1.0.10, the latter of which dispenses with its dependency ofbase64url.Vulnerabilities have been reported (by Whitesource and Synk) in
base64url< v3.0.0 and so we would like those versions to be excluded from our dependency tree.