Skip to content

Conversation

wonderdogone
Copy link

updated jws dependency to ~1.0.0 and all tests ran as passing.

updated jws dependency to ~1.0.0 and all tests ran as passing.
@frantello
Copy link

Tests not pass at all.

You should update travis.yalm file too, In this way:

language: node_js
node_js:

  • "0.10"

Using double quotes for version numbers.

I propose to use just 0.10 version and remove 0.8 souport, since node 0.10 is a mayor stable release and base64url just pass test compilance for 0.10.

You can read about chose node version to test.

@wonderdogone
Copy link
Author

I just ran mocha on the root directory and it sais passed(see screenshot). I'm curious
untitled
what I am missing?

@jfromaniello
Copy link
Member

maybe you are running on 0.10, but travis is running on 0.8

@jfromaniello
Copy link
Member

What's the reason to upgrading, btw?

@frantello
Copy link

node-jws encode to base64 using utf8, it had problem compatibility when decoded jwt at browser side,
because atob utility uses ascii. It happend with claims with latin characters, for example with a claim like name: "José".

Just encode a jwt with node-jsonwebtoken and try to decode it here http://jwt.io.

The "é" character is decoded with bad characters. It's fixed with new version of node-jws.

You can try with angular-jwt module. It is using window.atob when decode, with the same problem.

@jfromaniello jfromaniello mentioned this pull request Dec 21, 2014
@wonderdogone
Copy link
Author

yes I am on 0.10.34 and it seems ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants