-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add connection options to passwordless (#159) #160
Conversation
Can someone review my PR please? |
@wbhob can you keep our coding style (like not removing the semicolons)?. Also please try pushing your this branch again so the CI runs? |
Done @hzalaz edit and checks have passed |
Can I get a review, please? |
Can I please get a review on this PR? It's been open for 9 months and I've been complicit with your feedback. |
@wbhob can you please leave out all the code style changes and leave only the optional |
What do you mean? @luisrudge |
I mean there are a lot of style changes (added/removed semi colon, empty spaces etc). Can you clean those so the only change is the actual change you want to implement? We'll add prettier later and fix all those style issues automatically |
Done |
Thanks @wbhob 🎉 |
Thanks! |
Made it optional to pass in a connection string to passwordless ('sms' or 'email'). #159