Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connection options to passwordless (#159) #160

Merged
merged 10 commits into from
Dec 11, 2017
Merged

Add connection options to passwordless (#159) #160

merged 10 commits into from
Dec 11, 2017

Conversation

wbhob
Copy link
Contributor

@wbhob wbhob commented Feb 8, 2017

Made it optional to pass in a connection string to passwordless ('sms' or 'email'). #159

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.256% when pulling cde1e67 on wbhob:master into 1f345ba on auth0:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.256% when pulling f7613de on wbhob:master into 1f345ba on auth0:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.256% when pulling eb4c9c8 on wbhob:master into 1f345ba on auth0:master.

@wbhob
Copy link
Contributor Author

wbhob commented Jun 30, 2017

Can someone review my PR please?

@hzalaz
Copy link
Member

hzalaz commented Jul 7, 2017

@wbhob can you keep our coding style (like not removing the semicolons)?. Also please try pushing your this branch again so the CI runs?

@wbhob
Copy link
Contributor Author

wbhob commented Jul 7, 2017

Done @hzalaz

edit and checks have passed

@wbhob
Copy link
Contributor Author

wbhob commented Nov 21, 2017

Can I get a review, please?

@wbhob
Copy link
Contributor Author

wbhob commented Dec 11, 2017

Can I please get a review on this PR? It's been open for 9 months and I've been complicit with your feedback.

@luisrudge
Copy link
Contributor

@wbhob can you please leave out all the code style changes and leave only the optional connection param? Thanks for the PR 🎉

@wbhob
Copy link
Contributor Author

wbhob commented Dec 11, 2017

What do you mean? @luisrudge

@luisrudge
Copy link
Contributor

I mean there are a lot of style changes (added/removed semi colon, empty spaces etc). Can you clean those so the only change is the actual change you want to implement? We'll add prettier later and fix all those style issues automatically

@wbhob
Copy link
Contributor Author

wbhob commented Dec 11, 2017

Done

@luisrudge
Copy link
Contributor

Thanks @wbhob 🎉

@luisrudge luisrudge merged commit 0b9a5b4 into auth0:master Dec 11, 2017
@wbhob
Copy link
Contributor Author

wbhob commented Dec 11, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants