Rearrange exports for RSC and add experimental RSC route to example #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Widcket
reviewed
Nov 18, 2022
Widcket
reviewed
Nov 18, 2022
src/client/index.ts
Outdated
| WithPageAuthRequiredProps, | ||
| WithPageAuthRequiredOptions | ||
| } from './with-page-auth-required'; | ||
| export { ConfigProvider, ConfigProviderProps, useConfig }; |
There was a problem hiding this comment.
Do we want to export useConfig given that it's only used internally?
There was a problem hiding this comment.
Same for ConfigProvider and ConfigProviderProps.
There was a problem hiding this comment.
Yeah, that's a fair point, will fix
Widcket
reviewed
Nov 18, 2022
examples/kitchen-sink-example/app/profile-experimental-rsc/page.tsx
Outdated
Show resolved
Hide resolved
Widcket
reviewed
Nov 18, 2022
|
|
||
| const Header = (): React.ReactElement => { | ||
| const { user } = useUser(); | ||
|
|
||
| return ( | ||
| <header> | ||
| <div id="header"> |
There was a problem hiding this comment.
Nit: should this be a <nav>?
There was a problem hiding this comment.
It should be a <header> - but the Server Component renderer was throwing errors on <header>, so I changed it to a <div>
Widcket
reviewed
Nov 18, 2022
Widcket
reviewed
Nov 18, 2022
Co-authored-by: Rita Zerrizuela <zeta@widcket.com>
Widcket
approved these changes
Nov 18, 2022
Merged
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
/frontend->/clientto align with Next.js/client(egimport { useUser } from '@auth0/nextjs-auth0/client') because server components can't import client code/middleware->/edge(egimport { withMiddlewareAuthRequired } from '@auth0/nextjs-auth0/edge') because this export will include code that can run on the Edge runtime in Server Components and API Routes in addition to Middleware.