-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK-3553] Improved callback errors #835
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
6175197
Improved callback errors
adamjmcgrath b21c9b5
fix build
adamjmcgrath 9b41d9b
fix lint
adamjmcgrath 4d73667
fix tests
adamjmcgrath ffdd196
Add test for error instance checking and export error types
adamjmcgrath 93d1319
Apply suggestions from code review
adamjmcgrath File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
import type { errors } from 'openid-client'; | ||
|
||
export class MissingStateParamError extends Error { | ||
static message = | ||
'This endpoint must be called as part of the login flow (with a state parameter from the initial' + | ||
' authorization request).'; | ||
|
||
constructor() { | ||
/* c8 ignore next */ | ||
super(MissingStateParamError.message); | ||
Object.setPrototypeOf(this, MissingStateParamError.prototype); | ||
} | ||
} | ||
|
||
export class MissingStateCookieError extends Error { | ||
static message = | ||
'The cookie dropped by the login request cannot be found, check the url of the login request, the url of' + | ||
' this callback request and your cookie config.'; | ||
|
||
constructor() { | ||
/* c8 ignore next */ | ||
super(MissingStateCookieError.message); | ||
Object.setPrototypeOf(this, MissingStateCookieError.prototype); | ||
} | ||
} | ||
|
||
export class ApplicationError extends Error { | ||
constructor(rpError: errors.RPError) { | ||
/* c8 ignore next */ | ||
super(rpError.message); | ||
Object.setPrototypeOf(this, ApplicationError.prototype); | ||
} | ||
} | ||
|
||
export class IdentityProviderError extends Error { | ||
/** | ||
* The 'error_description' parameter from the AS response. | ||
* **WARNING** This can contain user input and is not escaped in any way. | ||
*/ | ||
errorDescription?: string; | ||
/** | ||
* The 'error' parameter from the AS response (Warning: this can contain user input and is not escaped in any way). | ||
*/ | ||
error?: string; | ||
|
||
/** | ||
* **WARNING** The message can contain user input and is not escaped in any way. | ||
*/ | ||
constructor(rpError: errors.OPError) { | ||
/* c8 ignore next */ | ||
super(rpError.message); | ||
this.error = rpError.error; | ||
this.errorDescription = rpError.error_description; | ||
Object.setPrototypeOf(this, IdentityProviderError.prototype); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this need the
Object.setPrototypeOf(this, MissingStateParamError.prototype)
for ES5? Same for all the other errors in this file.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch 👍 ffdd196