Adding support for Next 16 #2405
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2405 +/- ##
==========================================
+ Coverage 88.76% 90.04% +1.27%
==========================================
Files 39 40 +1
Lines 4486 4529 +43
Branches 887 918 +31
==========================================
+ Hits 3982 4078 +96
+ Misses 501 445 -56
- Partials 3 6 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6 tasks
src/server/next-compat.test.ts
Outdated
|
|
||
| import { toNextRequest, toNextResponse } from "./next-compat.js"; | ||
|
|
||
| describe("next-compact", () => { |
Contributor
There was a problem hiding this comment.
rename "next-compact" to "next-compat"
Suggested change
| describe("next-compact", () => { | |
| describe("next-compat", () => { |
Contributor
Author
There was a problem hiding this comment.
Thanks. I have updated it in this commit a716c40
Comment on lines
3
to
19
| /** | ||
| * Normalize a Request or NextRequest to a NextRequest instance. | ||
| * Ensures consistent behavior across Next.js 15 (Edge) and 16 (Node Proxy). | ||
| * @internal | ||
| */ | ||
| export function toNextRequest(input: Request | NextRequest): NextRequest { | ||
| if (input instanceof NextRequest) { | ||
| return input; | ||
| } | ||
|
|
||
| return new NextRequest(input.url, { | ||
| method: input.method, | ||
| headers: input.headers, | ||
| body: input.body as any, | ||
| duplex: (input as any).duplex ?? "half" | ||
| }); | ||
| } |
Contributor
There was a problem hiding this comment.
Do we want to consider cloning input request body before transforming? Just a suggestion, open to comments on this.
Contributor
Author
There was a problem hiding this comment.
Any specific reason ? We are not writing into the original input object, we are just reading from it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Next.js 16 Support (Node Proxy Compatibility)
This PR adds full compatibility for both Next 15 (Edge middleware) and Next 16 (Node proxy) runtimes, without requiring any app-level code changes.
🔧 Changes
Request normalization:
Added internal
toNextRequest()helper to safely convert a plainRequest(as used in Next 16 proxy) to aNextRequest.Used in:
middleware()getSession()updateSession()getAccessTokenForConnection()createFetcher()Response normalization:
Introduced internal
toNextResponse()helper for consistent cookie and header handling when a plainResponseis used.Backward-compatibility:
All existing examples and apps continue to work.
Developers only need to:
middleware.ts→proxy.tsmiddleware→proxyEdge vs Node behavior:
Next 15 still runs middleware on Edge.
Next 16 runs proxy in Node runtime (middleware remains deprecated but supported under
experimental.nodeMiddleware).