fix(session): prevent accidental deletion of legacy-named session cookie #2114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When migrating from
nextjs-auth0
v3
tov4
, developers may want to preserve the legacy session cookie name (appSession). However, in stateful mode, the SDK deletes the legacy cookie unconditionally after setting the new session cookie which leads to the newly set cookie being immediately removed if the names match.This behavior breaks login flows and causes unexpected session loss.
🛠️ Changes
This PR adds a conditional guard in StatefulSessionStore.set() to ensure that:
This prevents accidental deletion when session.name is set to
appSession
a common case during v3 to v4 upgrades.Reported Issue: #2111