Skip to content

Conversation

tusharpandey13
Copy link
Contributor

@tusharpandey13 tusharpandey13 commented Apr 28, 2025

Fixes: #2066 (Chunked v3 session cookies lost after v4 upgrade)

Changes

  • Updated cookie logic to recognize both current (__index) and legacy (.index) cookie name formats.
  • Added unit test for the same.

Testing

PASSING

@tusharpandey13 tusharpandey13 requested a review from a team as a code owner April 28, 2025 12:42
@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.51%. Comparing base (3ce7c59) to head (ba9c5be).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2071      +/-   ##
==========================================
+ Coverage   82.25%   82.51%   +0.26%     
==========================================
  Files          21       21              
  Lines        1989     2019      +30     
  Branches      348      352       +4     
==========================================
+ Hits         1636     1666      +30     
  Misses        347      347              
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tusharpandey13 tusharpandey13 changed the title feature/legacy chunked cookies Add missing support for legacy chunked cookies Apr 28, 2025
@tusharpandey13 tusharpandey13 enabled auto-merge (squash) May 12, 2025 10:52
@tusharpandey13 tusharpandey13 dismissed frederikprijck’s stale review May 13, 2025 06:30

these changes have been done

nandan-bhat
nandan-bhat previously approved these changes May 13, 2025
@tusharpandey13 tusharpandey13 merged commit d6e9711 into main May 13, 2025
10 of 12 checks passed
@tusharpandey13 tusharpandey13 deleted the feature/legacy-chunked-cookies branch May 13, 2025 11:38
@tusharpandey13 tusharpandey13 mentioned this pull request May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chunked v3 session cookies lost after v4 upgrade
4 participants