Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for encodeing postLogoutRedirectUri twice #127

Merged
merged 2 commits into from Jul 13, 2020
Merged

fix for encodeing postLogoutRedirectUri twice #127

merged 2 commits into from Jul 13, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jun 1, 2020

This pr fixes an issue in auth0.handleLogout(req, res) where the post redirect url was encoded twice causing issues logging out on identity. This still falls back to use the default Auth0 logout URL, thus existing behavior is not broken.

References

Solves the problem described in #126

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master
  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs

@chriskolenko
Copy link

Can confirm this fixes the double encoding problem for logout.

@sandrinodimattia
Copy link
Member

Thank you 👍 It introduces an other small issue, but I'll fix it separately.

@sandrinodimattia sandrinodimattia merged commit 1a997b3 into auth0:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants