async afterCallback signature should support terminating request

[alexmalev]

Checklist

• The issue can be reproduced in the sample app (or N/A).
• I have looked into the README and have not found a suitable solution or answer.
• I have looked into the examples and have not found a suitable solution or answer.
• I have looked into the API documentation and have not found a suitable solution or answer.
• I have searched the issues and have not found a suitable solution or answer.
• I have searched the Auth0 Community forums and have not found a suitable solution or answer.
• I agree to the terms within the Auth0 Code of Conduct.

Description

In version 2.0 the lib now supports terminating requests in afterCallback.

The contract is that afterCallback should not return session and instead do a res.end()

the problem is that the signature of afterCallback should change from:

export type AfterCallback = ( req: NextApiRequest, res: NextApiResponse, session: Session, state?: { [key: string]: any } ) => Promise<Session> | Session | undefined;

to
export type AfterCallback = ( req: NextApiRequest, res: NextApiResponse, session: Session, state?: { [key: string]: any } ) => Promise<Session | undefined> | Session | undefined;

otherwise we need to //@ts-ignore an async afterCallback that terminates instead of returning a session promise

Reproduction

const afterCallback = async (
  req: NextApiRequest,
  res: NextApiResponse,
  session: Session,
  state?: { [key: string]: any }
) => {
  if (session.user.isAdmin) {
    await doSomeAsyncStuff();
    return session;
  }
  res.status(401).end('User is not admin');
};

const handler = handleAuth({
  callback: handleCallback({ afterCallback }),
  })

throws: Type 'Promise<Session | undefined>' is not assignable to type 'Session | Promise | undefined'.
Type 'Promise<Session | undefined>' is not assignable to type 'Promise'

SDK version

2.0

Next.js version

13

Node.js version

16

[adamjmcgrath]

Thanks for raising this @alexmalev - will take a look at fixing this shortly, also happy to accept a PR if you want to expedite it

[adamjmcgrath]

Fixed by #954 - will be released in 2.0.1

Thanks @alexmalev!