Skip to content

Conversation

@stevehobbsdev
Copy link
Contributor

Changes

This PR adds id attributes to the password input and submit button
components. Other fields had ID attributes to them in #1517, so makes sense to
add them here.

References

Fixes #2067

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@stevehobbsdev stevehobbsdev marked this pull request as ready for review December 13, 2021 20:28
@stevehobbsdev stevehobbsdev requested a review from a team as a code owner December 13, 2021 20:28
@stevehobbsdev stevehobbsdev merged commit c692eb6 into master Dec 14, 2021
@stevehobbsdev stevehobbsdev deleted the fix/input-ids branch December 14, 2021 10:20
@stevehobbsdev stevehobbsdev mentioned this pull request Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:small Small review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No 'id' attribute on password input or login button

3 participants