Skip to content

Conversation

@stevehobbsdev
Copy link
Contributor

Changes

This PR allows the Lock build assets to be added to source control, which solves an issue with our build process where the build/ folder does not appear in the release package. This is used by those customers using Bower to consume our library, whilst also allowing our automated release system to work.

Previously the build files were force-commited just-in-time when making a release PR, but this has problems when working on the codebase post-release, as Git just wants to remove these files again, and the whole thing gets a bit messy.

References

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@stevehobbsdev stevehobbsdev requested a review from a team as a code owner October 6, 2021 14:27
@stevehobbsdev stevehobbsdev added the review:small Small review label Oct 6, 2021
@stevehobbsdev stevehobbsdev enabled auto-merge (squash) October 6, 2021 15:05
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. QQ; Do these files change again when you run yarn dist build without further changes?

@stevehobbsdev
Copy link
Contributor Author

@lbalmaceda They may do but they should also be auto-collapsed in the diff when reviewing a PR so hopefully they won't add too much noise.

@stevehobbsdev stevehobbsdev merged commit 6c9c270 into master Oct 8, 2021
@stevehobbsdev stevehobbsdev deleted the chore/build-assets branch October 8, 2021 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:small Small review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants