Stop minifying ESM and CommonJS for distribution #183
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonkoops
force-pushed
the
no-minified-js
branch
2 times, most recently
from
275edac to
b575407
Compare
jonkoops
force-pushed
the
no-minified-js
branch
from
b575407 to
ff1a21d
Compare
jonkoops
force-pushed
the
no-minified-js
branch
from
ff1a21d to
307f3de
Compare
|
Rebased the PR and fixed some merge conflicts, should be good to go now. |
|
IIRC, we do minify all our JS bundles, but I see the benefit here. Will discuss this with the team as this might be something we want to align (either keep it minified or avoid minifying all) across all our JS SDKs that get bundled. |
|
For bundles that get included directly in the browser I think that would make sense. For example, the UMD bundle is certainly one I expect to get loaded directly. However for ESM and CommonJS that is unlikely, as these are usually consumed by bundlers or Node.js, which would actually benefit from having things as close to source as possible. |
|
Closing this PR, as #192 will also handle this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the minification of the ESM and CommonJS bundles for distribution. There is no need to minify these files, as they will be consumed by Node.js and bundlers. Not minifying these files also improves debug-ability of these files, as source maps have to be opt-ed into in some environments.
This also removes the source maps from the package, as these are no longer required when shipping unminified source.