Add a prepublishOnly script for release
#157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, we always run npm run build already on our infrastructure prior to publishing automatically, this would unneccesarily add an additional build. Leaving it open as i want to see if it would make sense, but im afraird we might not pick up this change to avoid having to change our release set up. |
|
Just making sure, I will go ahead and close this one then 👍 |
|
Looks like I was a bit too early and closed this out before your edit, feel free to re-open if it makes sense. |
|
We needed this, sorry about that. I added it in #167 using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
prepublishOnlyscript, which will run before the package is published throughnpm publish. This script will run the build and tests, so that a broken package is not shipped by accident.