Empty string audience claim should be deserialized as empty string#663
Merged
jimmyjames merged 1 commit intomasterfrom Jun 9, 2023
Merged
Empty string audience claim should be deserialized as empty string#663jimmyjames merged 1 commit intomasterfrom
jimmyjames merged 1 commit intomasterfrom
Conversation
5 tasks
poovamraj
approved these changes
Jun 2, 2023
Contributor
poovamraj
left a comment
poovamraj
left a comment
There was a problem hiding this comment.
The code looks good if this is behaviour is what we would be going for
This was referenced Jan 22, 2025
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #662 - an empty audience string was being deserialized as an empty list, instead of a list with an empty string.