Fix for exp claim considered valid if equal to now
#652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmyjames
commented
Jan 26, 2023
| } | ||
|
|
||
| private boolean assertInstantIsPast(Instant claimVal, long leeway, Instant now) { | ||
| private boolean assertInstantIsLessThanOrEqualToNow(Instant claimVal, long leeway, Instant now) { |
There was a problem hiding this comment.
renamed this method to be clearer
evansims
approved these changes
Jan 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #646, the current date/time must be before the
expclaim's value.From the spec, section 4.1.4 (emphasis added):
This change ensures that the current time is before the
expclaim's value (if present).Fixes #646