Fix and document thread-safety #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbalmaceda
added
CH: Fixed
small
Widcket
reviewed
Jun 16, 2020
| @@ -365,20 +366,20 @@ public String toString() { | |||
| /** | |||
| * Sign the given content using this Algorithm instance. | |||
| * | |||
| * @param headerBytes an array of bytes representing the base64 encoded header content to be verified against the signature. | |||
| * @param headerBytes an array of bytes representing the base64 encoded header content to be verified against the signature. | |||
There was a problem hiding this comment.
Suggested change
| * @param headerBytes an array of bytes representing the base64 encoded header content to be verified against the signature. | |
| * @param headerBytes an array of bytes representing the base64 encoded header content to be verified against the signature. |
There was a problem hiding this comment.
white spaces are being added because the class wasn't properly formatted following the project defaults (IDE default settings).
Widcket
reviewed
Jun 16, 2020
lib/src/test/java/com/auth0/jwt/algorithms/HMACAlgorithmTest.java
Outdated
Show resolved
Hide resolved
Widcket
previously approved these changes
Jun 16, 2020
Co-authored-by: Rita Zerrizuela <zeta@widcket.com>
Widcket
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Made a few fixes to behave better in terms of thread-safety. Also, documented the thread-safety of the classes after our evaluation.
The reviewer might find useful to navigate the diff on a per-commit approach. The last commit is purely Javadoc changes.
References
Closes #419
Testing
I've added failure test cases right before the fix commit. Check the commit history.
Checklist