Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check varargs null values in JWTVerifier #412

Merged
merged 2 commits into from
Mar 25, 2020
Merged

Check varargs null values in JWTVerifier #412

merged 2 commits into from
Mar 25, 2020

Conversation

jimmyjames
Copy link
Contributor

Changes

Fixes #404

  • Check for null values on issuer and audience varargs arguments.
  • Also fixes test compile warnings for ambiguous null to vararg APIs.

References

Testing

  • This change adds test coverage

Checklist

@jimmyjames jimmyjames added CH: Fixed small This PR may require low effort to action, or contains few changes to review labels Mar 25, 2020
@jimmyjames jimmyjames requested a review from a team March 25, 2020 15:13
@jimmyjames jimmyjames mentioned this pull request Mar 25, 2020
Closed
5 tasks
damieng
damieng suggested changes Mar 25, 2020
View reviewed changes
lib/src/main/java/com/auth0/jwt/JWTVerifier.java Outdated
@@ -230,6 +230,20 @@ private void requireClaim(String name, Object value) {
}
}

private static boolean checkVarargNull(String[] args) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be checkVarArgNull ?

Maybe a better name might be isNullOrEmpty?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed to isNullOrEmpty

@jimmyjames jimmyjames requested a review from damieng March 25, 2020 15:33
@jimmyjames jimmyjames added this to the v3-Next milestone Mar 25, 2020
@jimmyjames jimmyjames merged commit 45036b9 into auth0:master Mar 25, 2020
@jimmyjames jimmyjames modified the milestones: v3-Next, 3.10.2 Mar 27, 2020
@jimmyjames jimmyjames mentioned this pull request Jun 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damieng damieng damieng approved these changes

Assignees
No one assigned
Labels
CH: Fixed small This PR may require low effort to action, or contains few changes to review
Projects
None yet
Milestone
3.10.2
Development

Successfully merging this pull request may close these issues.

Issue on setting audience/issuer as var-args (JWTVerifier)
2 participants
@jimmyjames @damieng