Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor HMACAlgorithm#getSecretBytes() so that it does not throw UnsupportedEncodingException #236

Closed
dmak opened this issue Jan 30, 2018 · 0 comments
Closed

Refactor HMACAlgorithm#getSecretBytes() so that it does not throw UnsupportedEncodingException #236

dmak opened this issue Jan 30, 2018 · 0 comments

Comments

@dmak
Copy link

dmak commented Jan 30, 2018 •
edited
Loading

It is easily possible to modify HMACAlgorithm#getSecretBytes() so that it does not throw UnsupportedEncodingException:

  • Use java.nio.charset.StandardCharsets.UTF_8 from Java7.
  • Use org.apache.commons.codec.Charsets.UTF_8 from Commons Codec.

Example:

return secret.getBytes(Charsets.UTF_8);
obecker added a commit to obecker/java-jwt that referenced this issue Feb 22, 2018
@obecker
Fix for issue auth0#236 - refactored HMACAlgorithm so that it doesn't…
f229898 
… throw an UnsupportedEncodingException
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmak @lbalmaceda