-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix panic threat when using type-cast for customClaims in validator #165
Conversation
I would appreciate it if you would approve running GitHub Actions for this PR when you have time. |
@Widcket ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @osamingo for the contribution! I left a few comments.
@sergiught I fixed it, PTAL. |
Codecov ReportBase: 89.05% // Head: 89.09% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #165 +/- ##
==========================================
+ Coverage 89.05% 89.09% +0.03%
==========================================
Files 7 7
Lines 274 275 +1
==========================================
+ Hits 244 245 +1
Misses 23 23
Partials 7 7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
47c3cdf
to
2bc0d47
Compare
Hey @osamingo 👋🏻 thanks a lot for the changes and apologies it took so while to get back to you! Would you mind adding a test case for this as well in the |
Hey @osamingo 👋🏻 I had some time and went ahead and added the test cases missing. Thanks for the contribution again! |
Description
The threat of panicking should be curbed by receiving a second return value when executing the type-cast.
References
Testing
Checklist
master
.