Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-1466] Allow to opt-out from sending SDK Telemetry - by setting `enableTelem… #78

Merged
merged 3 commits into from
Mar 27, 2020
Merged

[SDK-1466] Allow to opt-out from sending SDK Telemetry - by setting `enableTelem… #78

merged 3 commits into from
Mar 27, 2020

Conversation

adamjmcgrath
Copy link
Contributor

Description

Allow to opt-out from sending SDK Telemetry by setting enableTelmetry: false

This will prevent the library from sending the Auth0-Client header with the library and node version

References

https://auth0team.atlassian.net/wiki/spaces/SDL/pages/588286390/express-openid-connect+SDK#Sensitive-Data-Exposure

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@adamjmcgrath adamjmcgrath requested review from lbalmaceda and a team March 25, 2020 12:18
@adamjmcgrath adamjmcgrath changed the title Allow to opt-out from sending SDK Telemetry - by setting `enableTelem… [SDK-1466] Allow to opt-out from sending SDK Telemetry - by setting `enableTelem… Mar 26, 2020
@adamjmcgrath adamjmcgrath merged commit f141c1c into master Mar 27, 2020
@adamjmcgrath adamjmcgrath deleted the enable-telemetry branch July 17, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbalmaceda lbalmaceda Awaiting requested review from lbalmaceda

@damieng damieng Awaiting requested review from damieng

Assignees
No one assigned
Labels
CH: Added review:tiny Tiny review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamjmcgrath @damieng