transactionCookie configuration should be optional #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should have been optional from the start since it defaults to `session.cookie.sameSite` (or its default), see 2f427f4#diff-59cc4a3af1181865c858de26aa6d223f2c332351d061d6e6025d24fcd190bfb5R208
adamjmcgrath
approved these changes
Feb 22, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Should have been optional from the start since it defaults to
session.cookie.sameSite(or its default), see 2f427f4#diff-59cc4a3af1181865c858de26aa6d223f2c332351d061d6e6025d24fcd190bfb5R208References
#323
#334
#335
Testing
Covered in #323
Checklist
master