Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cookie chunking #275

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Fix cookie chunking #275

merged 1 commit into from
Aug 25, 2021

Conversation

adamjmcgrath
Copy link
Contributor

Description

res.cookie adds a default path to cookies so we should add a default one when measuring the default cookie string length.

References

fixes #269

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@adamjmcgrath adamjmcgrath added the review:small Small review label Aug 23, 2021
@adamjmcgrath adamjmcgrath requested a review from a team as a code owner August 23, 2021 11:54
@adamjmcgrath adamjmcgrath mentioned this pull request Aug 23, 2021
Closed
@adamjmcgrath adamjmcgrath merged commit 9bcc677 into master Aug 25, 2021
@adamjmcgrath adamjmcgrath deleted the fix-cookie-chunking branch August 25, 2021 08:55
This was referenced Sep 28, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehobbsdev stevehobbsdev stevehobbsdev approved these changes

Assignees
No one assigned
Labels
review:small Small review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v2.5.0 chunked cookie values exceed 4096 bytes
2 participants
@adamjmcgrath @stevehobbsdev