Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix session.cookie TS definitions #157

Merged
merged 4 commits into from
Oct 30, 2020
Merged

Fix session.cookie TS definitions #157

merged 4 commits into from
Oct 30, 2020

Conversation

adamjmcgrath
Copy link
Contributor

Description

Fix TS definitions for session.cookie

References

Fixes #156
Fixes #149

@adamjmcgrath adamjmcgrath added the review:tiny Tiny review label Oct 30, 2020
@adamjmcgrath adamjmcgrath requested a review from a team as a code owner October 30, 2020 13:09
@adamjmcgrath adamjmcgrath changed the title Cookie ts Fix session.cookie TS definitions Oct 30, 2020
@adamjmcgrath adamjmcgrath merged commit a9e39d3 into master Oct 30, 2020
@adamjmcgrath adamjmcgrath deleted the cookie-ts branch October 30, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederikprijck frederikprijck frederikprijck approved these changes

Assignees
No one assigned
Labels
review:tiny Tiny review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: "session.transient" is not allowed Typescript Definiton SessionConfigParams
2 participants
@adamjmcgrath @frederikprijck