fix(react): remove orange dot and prevent layout shift in formactions #68
+48
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Preview deploymentBranch: 📝 Preview URL: https://auth0-universal-components-f41s4jpzk-okta.vercel.app Updated at 2026-01-30T12:40:23.501Z |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
========================================
Coverage 84.99% 84.99%
========================================
Files 126 126
Lines 10569 10569
Branches 1352 1157 -195
========================================
Hits 8983 8983
Misses 1586 1586 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rax7389
added
bug
rax7389
reviewed
Jan 30, 2026
Comment on lines
+92
to
+94
| disabled={ | ||
| previousButtonProps.disabled || isLoading || (showUnsavedChanges && !hasUnsavedChanges) | ||
| } |
Contributor
There was a problem hiding this comment.
Interested to understand why we have to tweak this disabled logic?
| isLoading={isLoading} | ||
| showPrevious={showPrevious} | ||
| showNext={showNext} | ||
| showUnsavedChanges={false} |
Contributor
There was a problem hiding this comment.
any reason that we had to pass it here explicitly now?
rax7389
reviewed
Jan 30, 2026
| size={nextButtonProps.size} | ||
| disabled={nextButtonProps.disabled || isLoading} | ||
| className="FormActions-next" | ||
| className="FormActions-next min-w-[70px]" |
Contributor
There was a problem hiding this comment.
also lets have this value in rem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
UI polish fixes for the Organization Edit page FormActions component.
Changes
invisibleclass instead of conditional rendering, preserving its space in the layout when hiddenmin-w-[70px]to maintain consistent button width when spinner appears during loadingaria-hiddenandtabIndexfor the invisible Cancel button to improve screen reader and keyboard navigation behaviorReferences
Please include relevant links supporting this change such as a:
Testing
Checklist