-
Notifications
You must be signed in to change notification settings - Fork 1
feat(examples): bootstrap updated to work with all examples #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ff344b0 to
9078649
Compare
9078649 to
3b9ef66
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
=======================================
Coverage 83.17% 83.17%
=======================================
Files 125 125
Lines 10291 10291
Branches 1007 1007
=======================================
Hits 8560 8560
Misses 1731 1731 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -13,9 +13,9 @@ import { | |||
| displayChangePlan, | |||
| } from "./utils/discovery.mjs" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is another error, not sure if it's related to the PR, @NaveenChand755 can you take a look?
The scopes we are getting on SsoProvider page are not correct:
We should request:
"read:my_org:details update:my_org:details read:my_org:identity_providers create:my_org:identity_providers update:my_org:identity_providers delete:my_org:identity_providers update:my_org:identity_providers_detach read:my_org:identity_providers_provisioning create:my_org:identity_providers_provisioning delete:my_org:identity_providers_provisioning create:my_org:identity_providers_domains delete:my_org:identity_providers_domains read:my_org:identity_providers_scim_tokens create:my_org:identity_providers_scim_tokens delete:my_org:identity_providers_scim_tokens read:my_org:domains delete:my_org:domains create:my_org:domains update:my_org:domains read:my_org:configuration'"
But we are requesting:
"openid profile email create:my_org:identity_providers delete:my_org:identity_providers read:my_org:configuration read:my_org:details read:my_org:identity_providers update:my_org:details update:my_org:identity_providers update:my_org:identity_providers_detach"
Screen.Recording.2026-01-13.at.18.13.37.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that seems not related to the bootstrap script as the the request itself is missing the scope. Can we close this comment to merge this PR and then raise it as a separate issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not sure that this is not related to the script, maybe we need to change anything else. Can you @NaveenChand755 take a look?
Anyway I would not merge the PR until this is fixed because anyone that runs this script, will face the same issue, so scripts are not very useful unless we fix that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Folks I just dig into this today, and found the scopes mapped for the table page is limited and kept in UI components constant block-wise, if we want to club all the scopes for accessing the actions of other pages(like edit) I am really not sure about, @NaveenChand755 you can weigh in on this. Additionally I ran script and generated the the app using @mustafadeel branch and run the code in existing main I see the similar thing confirming that the recent script changes are not impacting this specific flow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @castrinho18 @rax7389 yes for the sso provider table components its just
openid profile email create:my_org:identity_providers delete:my_org:identity_providers read:my_org:configuration read:my_org:details read:my_org:identity_providers update:my_org:details update:my_org:identity_providers update:my_org:identity_providers_detach
for edit flow we will have request for
read:my_org:details update:my_org:details read:my_org:identity_providers create:my_org:identity_providers update:my_org:identity_providers delete:my_org:identity_providers update:my_org:identity_providers_detach read:my_org:identity_providers_provisioning create:my_org:identity_providers_provisioning delete:my_org:identity_providers_provisioning create:my_org:identity_providers_domains delete:my_org:identity_providers_domains read:my_org:identity_providers_scim_tokens create:my_org:identity_providers_scim_tokens delete:my_org:identity_providers_scim_tokens read:my_org:domains delete:my_org:domains create:my_org:domains update:my_org:domains read:my_org:configuration
fix: creating client api syntax
a57d909 to
1449105
Compare
By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
References
Todo:
Testing
Checklist