[SDK-2750] Expose mfa_token from the mfa_required error when getting new tokens #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederikprijck
commented
Sep 6, 2021
| @@ -133,16 +133,20 @@ export async function getJSON<T>( | |||
| } | |||
|
|
|||
| const { | |||
| json: { error, error_description, ...success }, | |||
| json: { error, error_description, ...data }, | |||
There was a problem hiding this comment.
Renamed this to data, because it contains the mfa_token and it was a bit weird to use success in case of an error.
frederikprijck
added
CH: Added
frederikprijck
commented
Sep 6, 2021
| @@ -30,7 +30,7 @@ export class AuthenticationError extends GenericError { | |||
| public state: string, | |||
| public appState: any = null | |||
| ) { | |||
| super(error, error_description); | |||
| super(error, error_description) /* istanbul ignore next */; | |||
There was a problem hiding this comment.
Added a few istanbul ignores, see gotwarlost/istanbul#690
stevehobbsdev
requested changes
Sep 7, 2021
stevehobbsdev
approved these changes
Sep 8, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When mfa is enabled, the
/tokenendpoint can return amfa_requirederror. In the case that it does, it also included amfa_tokenproperty, which we are currently ignoring.This PR introduces a
MfaRequiredErrorclass that is used to unwrap the above information in case of amfa_requirederror, exposing themfa_tokento the users.