Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower tvOS deployment target to 9.0 #100

Merged
merged 1 commit into from
Jan 11, 2020
Merged

Lower tvOS deployment target to 9.0 #100

merged 1 commit into from
Jan 11, 2020

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Jan 11, 2020 •
edited
Loading

Changes

Changed

  • Lowered the actual tvOS deployment target to 9.0. While the declared deployment target (in the Podspec) is 9.0, in the pbxproj the actual deployment target is 9.2. There's no real need for 9.2, as the library is not using any API that requires that minimum tvOS version. And it's blocking an upcoming feature in Auth0.swift that requires backwards compatibility.

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket requested a review from a team January 11, 2020 00:25
@Widcket Widcket added this to the vNext milestone Jan 11, 2020
@Widcket Widcket merged commit 0d7476d into master Jan 11, 2020
@Widcket Widcket deleted the fix/tvos-version branch January 11, 2020 20:37
@Widcket Widcket mentioned this pull request Jan 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshcanhelp joshcanhelp joshcanhelp approved these changes

Assignees
No one assigned
Labels
CH: Changed P2: Very Important S2: Inconvenient
Projects
None yet
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Widcket @joshcanhelp