Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target SDK 28. Update Wrapper and OSS plugin #30

Merged
merged 1 commit into from
Nov 20, 2018
Merged

Conversation

lbalmaceda
Copy link
Contributor

@lbalmaceda lbalmaceda commented Nov 20, 2018

Note

People using this library from version 1.12.0 and up should start targeting latest android SDK versions, as recommended by Google. Those running into conflicts because of different com.android.support libraries versions can choose to use latest release 28.0.0 or exclude the ones required by this library and require a different version in their app's build.gradle file as explained in the readme

@lbalmaceda lbalmaceda added this to the v1-Next milestone Nov 20, 2018
Copy link
Contributor

@joshcanhelp joshcanhelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lbalmaceda lbalmaceda changed the title Update Gradle Wrapper and OSS plugin Target SDK 28. Update Wrapper and OSS plugin Nov 20, 2018
@lbalmaceda lbalmaceda merged commit 1c472e8 into master Nov 20, 2018
@lbalmaceda lbalmaceda deleted the update-oss-plugin branch November 20, 2018 20:44
@lbalmaceda lbalmaceda modified the milestones: v1-Next, 1.2.0 Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants