Skip to content

fix: Fixing the memory leak introduced in the DPoP flow #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pmathew92 merged 1 commit into from
Jan 7, 2026
Merged

fix: Fixing the memory leak introduced in the DPoP flow #891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions auth0/src/main/java/com/auth0/android/dpop/DPoP.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@ public data class HeaderData(val authorizationHeader: String, val dpopProof: Str
* Class for securing requests with DPoP (Demonstrating Proof of Possession) as described in
* [RFC 9449](https://datatracker.ietf.org/doc/html/rfc9449).
*/
public class DPoP(private val context: Context) {
public class DPoP(context: Context) {

private val applicationContext: Context = context.applicationContext

Copy link

@sanchitmehta94 sanchitmehta94 Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my understanding . holding activity context would cause issue DPoP instance lives longer than activity and causing activity to not GC?

Copy link
Contributor Author

@pmathew92 pmathew92 Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

/**
* Determines whether a DPoP proof should be generated for the given URL and parameters. The proof should
Expand Down Expand Up @@ -79,7 +81,7 @@ public class DPoP(private val context: Context) {
*/
@Throws(DPoPException::class)
internal fun generateKeyPair() {
DPoPUtil.generateKeyPair(context)
DPoPUtil.generateKeyPair(applicationContext)
}

/**
Expand Down
1 change: 1 addition & 0 deletions auth0/src/test/java/com/auth0/android/authentication/AuthenticationAPIClientTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ public class AuthenticationAPIClientTest {
mockAPI = AuthenticationAPIMockServer()
mockKeyStore = mock()
mockContext = mock()
whenever(mockContext.applicationContext).thenReturn(mockContext)
val auth0 = auth0
client = AuthenticationAPIClient(auth0)
gson = GsonBuilder().serializeNulls().create()
Expand Down
2 changes: 2 additions & 0 deletions auth0/src/test/java/com/auth0/android/dpop/DPoPTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ public class DPoPTest {
mockResponse = mock()
mockKeyStore = mock()
mockResponseBody = mock()

whenever(mockContext.applicationContext).thenReturn(mockContext)
dPoP = DPoP(mockContext)

DPoP._auth0Nonce = null
Expand Down
1 change: 1 addition & 0 deletions auth0/src/test/java/com/auth0/android/provider/WebAuthProviderTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ public class WebAuthProviderTest {

mockKeyStore = mock()
mockContext = mock()
Mockito.`when`(mockContext.applicationContext).thenReturn(mockContext)

DPoPUtil.keyStore = mockKeyStore

Expand Down
Loading