Integrate auth0-spa-js #82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any idea when this will be reviewed/approved, merged, and supported with QuickStart documentation? |
|
@nicbavetta the sample is good to go. We're just waiting for another internal review from someone that has more experience with real world vue apps. The actual docs/quickstarts will take a bit more time though, no ETA yet. |
Awesome, thanks for the quick response. The source code is enough - the documentation is just icing on the cake. :) |
added 5 commits
August 29, 2019 13:39
Also installed `core-js@2.6.9`, to fix an issue with `auth0-spa-js` installing `core-js@3.2.1`, which is incompatible with `@vue/babel-preset-app`.
- Renamed `authService` to move away from the "service" naming - Used destructuring for config values - Copied plugin into the wrapper file and named `Auth0Plugin`
For consistency with the other new quickstarts. Also fixed references in README and CircleCI config
stevehobbsdev
force-pushed
the
upgrade-sdk
branch
from
5921d97 to
3cb0023
Compare
stevehobbsdev
force-pushed
the
upgrade-sdk
branch
from
3cb0023 to
02c7568
Compare
luisrudge
approved these changes
Sep 27, 2019
Transferred tutorial for scenario 03 Inlined the 'create the backend API' include wip wip
stevehobbsdev
pushed a commit
that referenced
this pull request
Sep 27, 2019
commit f70c571 Author: Steve Hobbs <steve.hobbs.mail@gmail.com> Date: Fri Sep 27 14:52:25 2019 +0100 Merge from master commit 153900b Author: Michael Arias <michael.arias.93@gmail.com> Date: Thu Sep 12 21:00:24 2019 -0400 Transferred 01-Login tutorial from docs Transferred tutorial for scenario 03 Inlined the 'create the backend API' include wip wip commit 30d7647 Merge: 346bc18 925fc8b Author: Steve Hobbs <steve.hobbs.mail@gmail.com> Date: Fri Sep 27 11:13:59 2019 +0100 Merged master to resolve conflicts commit 346bc18 Author: Steve Hobbs <steve.hobbs.mail@gmail.com> Date: Mon Sep 23 15:06:49 2019 +0100 Updated call button text inline with documentation commit 02c7568 Author: Steve Hobbs <steve.hobbs.mail@gmail.com> Date: Mon Sep 16 10:16:27 2019 +0100 Fixed app renames commit 058fed3 Author: Steve Hobbs <steve.hobbs.mail@gmail.com> Date: Mon Sep 16 10:16:11 2019 +0100 Fixed broken import commit d468159 Author: Steve Hobbs <steve.hobbs.mail@gmail.com> Date: Tue Sep 10 12:02:00 2019 +0100 Renamed folder 03-Calling-an-API to 02-Calling-an-API For consistency with the other new quickstarts. Also fixed references in README and CircleCI config commit 5bfb7e3 Author: Steve Hobbs <steve.hobbs.mail@gmail.com> Date: Mon Sep 9 11:56:33 2019 +0100 Changes in-keeping with the tutorial - Renamed `authService` to move away from the "service" naming - Used destructuring for config values - Copied plugin into the wrapper file and named `Auth0Plugin` commit 7415973 Author: Steve Hobbs <steve.hobbs.mail@gmail.com> Date: Tue Sep 3 16:34:13 2019 +0100 Updated auth0-spa-js to 1.2.3 commit b84028f Author: Steve Hobbs <steve.hobbs.mail@gmail.com> Date: Thu Aug 29 13:47:22 2019 +0100 Homepage content styling commit 6464aa2 Author: Steve Hobbs <steve.hobbs.mail@gmail.com> Date: Thu Aug 29 13:33:42 2019 +0100 Updated dependencies Also installed `core-js@2.6.9`, to fix an issue with `auth0-spa-js` installing `core-js@3.2.1`, which is incompatible with `@vue/babel-preset-app`. commit ed35ae7 Author: Steve Hobbs <steve.hobbs.mail@gmail.com> Date: Thu Jul 18 11:36:53 2019 +0100 Integrated new SDK into sample 03 commit 854a822 Author: Steve Hobbs <steve.hobbs.mail@gmail.com> Date: Wed Jul 17 14:58:45 2019 +0100 Integrated auth0-spa-js into sample 01 commit fd26709 Author: Steve Hobbs <steve.hobbs.mail@gmail.com> Date: Wed Jul 17 11:12:35 2019 +0100 Updated dependencies
|
This PR has been merged locally and pushed 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates from
auth0-jstoauth0-spa-js. It also implements some developer feedback, mostly around refactoring some components. This refactors both sample 01 and 03.Key points:
authService.jsis refactored to use the new SDK. This has been influenced by the design of the React wrapper and can similarly be extracted out into its own library in the future.authGuard.jsis a new thing that protects routes from unauthenticated access. This can similarly be extracted out into the wrapper libraryMerging of this PR should be done in tandem with the associated documentation, which is not available yet.