Skip to content

Commit

Permalink
[PATCH] knfsd: nfsd4: fix open_confirm locking
Browse files Browse the repository at this point in the history
Fix an improper unlock in an error path.

Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Signed-off-by: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
J. Bruce Fields authored and Linus Torvalds committed Jun 30, 2006
1 parent 7e40536 commit a8cddc5
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions fs/nfsd/nfs4state.c
Original file line number Diff line number Diff line change
Expand Up @@ -2252,8 +2252,9 @@ nfsd4_open_confirm(struct svc_rqst *rqstp, struct svc_fh *current_fh, struct nfs
(int)current_fh->fh_dentry->d_name.len,
current_fh->fh_dentry->d_name.name);

if ((status = fh_verify(rqstp, current_fh, S_IFREG, 0)))
goto out;
status = fh_verify(rqstp, current_fh, S_IFREG, 0);
if (status)
return status;

nfs4_lock_state();

Expand Down

0 comments on commit a8cddc5

Please sign in to comment.