-
Notifications
You must be signed in to change notification settings - Fork 1
UPSTREAM PR #18401: ggml: add ggml_rope_comp #717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
loci-dev
wants to merge
20
commits into
main
Choose a base branch
from
upstream-PR18401-branch_ngxson-xsn/rope_v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f14c301 to
c7d40d0
Compare
f2e8c7f to
b3f45e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored from ggml-org/llama.cpp#18401
For the motivation of this proposal, please refer to this discussion: ggml-org/ggml#1401
For demo purposes, only 2 backends are implemented in this PR:
Main differences
freq_base, YaRN scaling[1] This is necessary because we may want to implement 2D-rope (vision mode) as 2 separated calls to
ggml_rope_comp, one call withoffset = 0and the other withoffset = n_rot/2. This is particularly useful for vision models like Pixtral, where the 2 parts of 2D-rope does not use the same freq configuration.Performance
I still couldn't get a meaningful perf result due to
--output csvnot working withtest-backend-ops. But at a glance via--output console, it provide the same performance as the existingggml_rope_ext