-
Notifications
You must be signed in to change notification settings - Fork 268
feat: upgraded to Pinecone v7 #633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
note: we no longer use pinecone-client and instead is just pinecone |
All references to PINECONE_API_BASE_URL for Pinecone Local now use http://localhost:5080 (not http://pinecone:5080). |
POSTGRES_HOST: postgres | ||
POSTGRES_PORT: 5432 | ||
POSTGRES_DB: postgres | ||
POSTGRES_USER: postgres | ||
POSTGRES_PASSWORD: postgres |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are not needed by postgres in the tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes — not needed. In tests:
The Dagger job binds the Postgres service as postgres:5432.
.dagger/src/semantic_router_ci/main.py sets these envs inside the test container with sensible defaults:
POSTGRES_HOST=postgres
POSTGRES_PORT=5432
POSTGRES_DB=postgres
POSTGRES_USER=postgres
POSTGRES_PASSWORD=postgres
Since we set them in the container with defaults, the workflow doesn’t need to pass them.
Kept the defaults in main.py and removed the redundant workflow-level Postgres envs.
…all in .dagger/src/semantic_router_ci/main.py
…es/pinecone-v7.md
….py around index creation
…index/pinecone.py
Add unit tests covering the gRPC toggle path, creation options, and namespace helpers. Update docs to describe transport, deletion_protection, tags, and the new helper methods.
This reverts commit 9ef3a7f.
This reverts commit e23210e.
PR Type
Enhancement
Description
Upgrade Pinecone SDK dependency to v7
Adapt client init to Pinecone v7 API
Update installation error message text
Adjust version spec in pyproject.toml
File Walkthrough
pinecone.py
Adapt Pinecone client to v7 API
semantic_router/index/pinecone.py
Pinecone
andServerlessSpec
for v7 APIpyproject.toml
Bump Pinecone dependency to v7
pyproject.toml
pinecone
dependency to >=7.0.0,<8.0.0