Skip to content

Conversation

clioo
Copy link

@clioo clioo commented Feb 8, 2025

  • Add a new client parameter to PineconeIndex.__init__ for dependency injection.
  • Use the supplied client if provided, otherwise initialize a new Pinecone client.
  • Maintain backward compatibility while improving testability and configuration flexibility.
  • removing duplication on api_key

Fixes #525

- Add a new `client` parameter to `PineconeIndex.__init__` for dependency injection.
- Use the supplied client if provided, otherwise initialize a new Pinecone client.
- Maintain backward compatibility while improving testability and configuration flexibility.
- removing duplication on api_key

Fixes aurelio-labs#525
@jamescalam jamescalam self-assigned this Feb 8, 2025
@jamescalam jamescalam added the enhancement Enhancement to existing features label Feb 8, 2025
@jamescalam jamescalam self-requested a review February 8, 2025 05:51
@jamescalam
Copy link
Member

thanks for the pr @clioo — I see issues in the lint, are you able to take a look? The linter can be run locally with poetry run make lint

The test failure potentially looks like it is due to api keys — I'll test locally once linting is resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement to existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SSL Issue with Pinecone in Semantic Router

2 participants