feat(config): support global config option for default validation trigger #536
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #535.
I moved
AureliaValidationConfiguration
to a separate file and added a methoddefaultValidationTrigger
that users can call to globally configure the default validation trigger like so:I wasn't sure how to get the configured trigger into the
ValidationController
so I simply opted to register the config instance and inject it.I considered making
AureliaValidationConfiguration.getDefaultValidationTrigger()
private to present a cleaner interface to users, but decided against it since this way the call in theValidationController
constructor can be type-checked.