-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ValidationRules): add number validation rules #519
feat(ValidationRules): add number validation rules #519
Conversation
Add common validation rules for numeric properties. resolves aurelia#440
I am unsure about a proper validation message for |
@CuddleBunny Nice. Maybe it will cause a big confusion without clear documentation, can you help add something too. Also about that, should there be |
@bigopon I can update the documentation, it has moved outside to aurelia/documentation right? Splitting range into two rules is also a good idea. Perhaps just |
@CuddleBunny Yes indeed. Docs are now here: https://github.com/aurelia/documentation/blob/master/current/en-us/7.%20plugins/3.%20validation.md Ping me on the docs PR and we'll get these things in together. |
#518 should go before this @EisenbergEffect @fkleuver |
I think so ... cc @fkleuver |
Any reason for the documentation to show these when this Pull Request isn't even merged? I had to look in the source code to make sure I wasn't using those rules incorrectly. |
@EisenbergEffect - are we waiting on anything to merge this so that it matches the docs that have been deployed? |
Apologies! I must have deployed the docs to update something else and forgot this was in there. We've got the dependency merged, so I'm merging this now. I'll work on getting a release out in the next day or two. As things look at the moment, probably tomorrow (Friday afternoon Pacific). |
Add common validation rules for numeric properties.
resolves #440