update dotnet template to netcoreapp2.1, fix Index.cshtml

[milkshakeuk]

Update the dotnet template but as well as updating the Index.cshtml which fixes #979

[milkshakeuk]

the reason this Travis Build is failing is because of a malicious dependency of event-stream called flatmap-stream see here

[3cp]

You can rebase/merge latest master now.

[EisenbergEffect]

@milkshakeuk We've merged the event-stream fix into master. If you can rebase and ping me, I'll do a final review and we'll get this in. Thanks!

[milkshakeuk]

@EisenbergEffect the pull request has been rebased and is ready for review.

[EisenbergEffect]

@huochunpeng Can you do a review as well? Looks good to me. Let me know your thoughts.

[3cp]

Hoho, I know nothing about dotnet :-)

[3cp]

I will have a look tomorrow, but my exp is probably limited at the cli side. @chrisckc could you have a look?

[3cp]

Most code are dotnet templates that I am not familiar. But the few lines of cli code look good to me.

[EisenbergEffect]

It looks fine as well, from what I can tell, but I'm not the expert. Let me see if I can get a core team .NET user to give this a test as well

[Alexander-Taran]

@milkshakeuk could you explain
.SetCompatibilityVersion(CompatibilityVersion.Version_2_1);
and
UseHsts()
lines..
They seem opinionated
And if so - should be commented.
As in "as better developers we want to enforce https early.."
That is if I'm getting this line right.

And compatibility I don't get.
I've lost track of .net core

[milkshakeuk]

@Alexander-Taran the changes I have added are taken pretty much verbatim from the result of dotnet new mvc .

None of what I have added is opinionated on my part but if your interested in the reasons behind the SetCompatibilityVersion see here.

There is also some information in the official docs relating to UseHsts.

[EisenbergEffect]

Thanks for working on this @milkshakeuk ! Merging it in for the next release.