Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(input): #512 added autocomplete attribute #516

Merged
merged 1 commit into from
Jun 3, 2018

Conversation

zwalters
Copy link
Collaborator

@zwalters zwalters commented Jun 1, 2018

No description provided.

@MaximBalaganskiy
Copy link
Collaborator

According to the definition the default value is "on" which is different to our default. Also, in most cases users won't use the attribute at all but we will add it to the DOM through the binding. I think it would be better to treat the attribute similar to placeholder. What do you recon?

@zwalters
Copy link
Collaborator Author

zwalters commented Jun 1, 2018

You're right. I'll set it similar to placeholder.

@zwalters
Copy link
Collaborator Author

zwalters commented Jun 1, 2018

How about we add it only if the value is off?

if(this.autocomplete == "off"){ this.input.setAttribute("autocomplete", this.autocomplete); }

@MaximBalaganskiy
Copy link
Collaborator

MaximBalaganskiy commented Jun 1, 2018 via email

@zwalters
Copy link
Collaborator Author

zwalters commented Jun 2, 2018

Huh, that's neat. Good to know

@MaximBalaganskiy MaximBalaganskiy merged commit c964eda into aurelia-ui-toolkits:v1 Jun 3, 2018
@MaximBalaganskiy
Copy link
Collaborator

Fixes #512

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants