Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sample): add cards actions sample #468

Merged
merged 1 commit into from
Sep 5, 2017
Merged

chore(sample): add cards actions sample #468

merged 1 commit into from
Sep 5, 2017

Conversation

vbornand
Copy link
Contributor

No description provided.

@vbornand
Copy link
Contributor Author

Fix the issue #467

@Thanood
Copy link
Collaborator

Thanood commented Sep 5, 2017

Sorry for responding so late. A lot of real life happened..
I've tried the sample but the actions on the last card should only be visible when the card is revealed, right?

I will have a look but maybe you already know a solution. 😃
Also, in #467 you mentioned you'd like to update the gist so I'm wondering if this PR links to the most recent gist.

@vbornand
Copy link
Contributor Author

vbornand commented Sep 5, 2017

Hello,

I updated this gist this morning, and find a bug corrected in the PR #476.

When you will do a new release, my gist will work.

@Thanood Thanood merged commit fec4c02 into aurelia-ui-toolkits:master Sep 5, 2017
@Thanood
Copy link
Collaborator

Thanood commented Sep 5, 2017

I'll try it.
Not sure if I can do a release today, I'm coming home late.
But I will create one tomorrow the latest.

Would be nice to fix that AMD issue (#473) before that but I guess I'll need to go on without it for now.

@Thanood
Copy link
Collaborator

Thanood commented Sep 5, 2017

I think I got the text in the card wrong.
It says:

This card has reveal true and the actions are visible only when the card is revealed.

But actually, if the actions are not made sticky, the reveal will appear above the card actions.
(btw. I don't think my sentence above makes that any clearer 😂 )

@vbornand
Copy link
Contributor Author

vbornand commented Sep 5, 2017

You are right, the text on the last card was wrong. I updated the gist.

@vbornand
Copy link
Contributor Author

vbornand commented Sep 7, 2017

Thank you for the new release, Can you please provide this file: "https://rawgit.com/aurelia-ui-toolkits/aurelia-materialize-bundles/0.31.0/config2.js"

I already update my gist to use it.

EDIT: The gist works here (http://aurelia-ui-toolkits.github.io/demo-materialize/#/samples/card-actions), but not when you open it on gist run (https://gist.run/?id=8ce0d3ac7ca2029f932c3dde1937fc6f)

@Thanood
Copy link
Collaborator

Thanood commented Sep 7, 2017

Done! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants