Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(md-tabs): reset click event in refresh method to allow dynamically added tabs #464

Merged
merged 1 commit into from
Jul 20, 2017

Conversation

swalters
Copy link
Contributor

to fire the custom tabSelected event

@Thanood
Copy link
Collaborator

Thanood commented Jul 20, 2017

Thanks. 👍

Can you change the commit message to use our commit message convention, please? It's used to generate the changelog. 😃

Although I could add to the changelog manually this time.

@swalters swalters changed the title reset click event in refresh method to allow dynamically added tabs fix(md-tabs): reset click event in refresh method to allow dynamically added tabs Jul 20, 2017
@swalters
Copy link
Contributor Author

That's what I get for hurrying :) Does editing the PR commit do it or do I need to submit another PR with correct verbiage?

@Thanood
Copy link
Collaborator

Thanood commented Jul 20, 2017

I'm not sure, tbh. Maybe there is a way in Github/git to change it..
It's possible before pushing to change the commit message.

You did it while I was writing. 😄

@swalters
Copy link
Contributor Author

Yes, it wasn't as painful as I thought

@Thanood Thanood merged commit fcfe3f6 into aurelia-ui-toolkits:master Jul 20, 2017
@Thanood
Copy link
Collaborator

Thanood commented Jul 20, 2017

How did you do it?

@swalters
Copy link
Contributor Author

@Thanood
Copy link
Collaborator

Thanood commented Jul 20, 2017

Awesome, thanks! 👍
I will save the link for later (and I hope I don't forget that I saved it -,-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants