Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(md-dropdown): remove legacy fix #463

Merged
merged 2 commits into from
Jul 20, 2017
Merged

refactor(md-dropdown): remove legacy fix #463

merged 2 commits into from
Jul 20, 2017

Conversation

vbornand
Copy link
Contributor

Same as PR #461 and #462 but with correct convention and correct files.

As discussed in the issue #458 I've removed the legacy dropdown-fix. It was for an old version of materialize and not used by default.

Breaking changes:

  • The method useDropdownFix doesn't exist anymore.

@Thanood
Copy link
Collaborator

Thanood commented Jul 20, 2017

I wonder if we should issue a warning if someone still uses .useDropdownFix(). Maybe just a simple console.warn in config-builder.js.

@vbornand
Copy link
Contributor Author

Ok I add a warning

@vbornand
Copy link
Contributor Author

What do you think of:
console.warn("The method useDropdownFix has no effect in this version and will be removed in a future version.");

@Thanood
Copy link
Collaborator

Thanood commented Jul 20, 2017

I like that. 😃

@Thanood Thanood merged commit 83c1180 into aurelia-ui-toolkits:master Jul 20, 2017
@vbornand vbornand deleted the md-dropdown-removefix3 branch July 20, 2017 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants