Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stopPropagation option on dropdown #457

Closed
wants to merge 3 commits into from
Closed

Add stopPropagation option on dropdown #457

wants to merge 3 commits into from

Conversation

vbornand
Copy link
Contributor

Fix the issue #451

@vbornand
Copy link
Contributor Author

vbornand commented Jul 20, 2017

This PR add this option only to the custom attribute and not on the element.

@vbornand
Copy link
Contributor Author

I updated the PR, now it add the option to the attribute and to the element.

@Thanood
Copy link
Collaborator

Thanood commented Jul 20, 2017

Thanks a lot! 👍
The element is a placeholder, btw. I've tried that in the beginning and went with the attribute instead. Maybe we should remove that.

One thing: could you use a commit message which corresponds to our commit message convention? The format is readable by conventional-changelog and will be used to generate release notes.

For this case it would be: feat(md-dropdown): add stopPropagation option.
No need to change the commits now, I can adapt the changelog manually. Just for next time maybe. 😃

@vbornand
Copy link
Contributor Author

I will open again a pull request with a single commit and clean message. Don't spend your time to correct this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants