feat(validation): delegate validation rendering to custom elements #432
Conversation
Custom elements will be able to take control over validation by defining rendering methods on a DOM element
|
@MaximBalaganskiy This is a great idea! The element itself always knows best how it should be rendered. 👍 I wondered if |
|
My initial idea was to keep everything on an element but those two methods will be called from almost every class so to follow DRY I put them on the renderer. |
|
Yes, I agree. If the element needs some custom behaviour it just wouldn't call |
|
@MaximBalaganskiy Is there anything to add/discuss here (apart from other components like select)? |
|
We've also got a date picker to convert, other than that I don't see anything else to add |
Before the change mdRenderValidateResult function was called for each validation result which worked fine while validation messages were displayed. The problem was that validation border was shown based on a presence of validation messages. It there were none - no error border. To fix the issue an element must have all the validation results and render them all at once.
Default rendering functions are called for elements which do not provide their own. Effectively, only INPUT is supported.
|
I refactored the initial solution and updated all initially supported elements |
MaximBalaganskiy
changed the title
Custom elements will be able to take control over validation by defining rendering methods on a DOM element