Update renderer to properly show validation result #343
Conversation
When a form is loaded and you start editing an input making it valid straightaway it is not reflected on the input. This is because renderer ignores valid validation results and there are no invalid results to be removed which would normally add `valid` class. By moving setting `valid` and `invalid` classes to a separate cycle we will make sure that correct validation status will always be applied to the input.
|
Thanks! 👍 It would be great if you used our commit message conventions (basically angular style messages) so things like this can be auto-generated into a change log. 😃 I'll change it on my side for this PR. |
|
@Thanood Consider including a link to the commit guidelines in https://github.com/aurelia-ui-toolkits/aurelia-materialize-bridge/blob/master/CONTRIBUTING.md and a mention to not prep rel for PRs ;) |
|
@Kukks: done! |
Sure, will do :) |
|
@Thanood, as a person that had to fork and use my own for my projects, I always prepared release for my repo before I opened PRs to you and I recall it not being nice due to the big diff in the PR generated. |
|
Ah, thanks for clarifying. Good point. 👍 |
When a form is loaded and you start editing an input making it valid straightaway it is not reflected on the input.
This is because renderer ignores valid validation results and there are no invalid results to be removed which would normally add
validclass.By moving setting
validandinvalidclasses to a separate cycle we will make sure that correct validation status will always be applied to the input.