Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(md-progress): set md-pixel-size on attached #325

Merged
merged 1 commit into from
Nov 29, 2016

Conversation

mattgaspar
Copy link
Contributor

md-pixel-size was not working if set to a static value or set before the attached event. It was only working as used in the sample but didn't work as it would typically be used.

Also, let mdSize remain set when mdPixelSize is set. mdPixelSize overrides mdSize due to inline styles having higher priority.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.154% when pulling b7a83a7 on mattgaspar:master into 7bc059a on aurelia-ui-toolkits:master.

@Thanood
Copy link
Collaborator

Thanood commented Nov 29, 2016

@mattgaspar Thanks a lot. 👍

So, that empty bind() has a side-effect, is that right?
Any idea if that's intended from Aurelia's side? Looks a bit like "magic", tbh.

Also, let mdSize remain set when mdPixelSize is set. mdPixelSize overrides mdSize due to inline styles having higher priority.

Good catch, thanks! 😃

@mattgaspar
Copy link
Contributor Author

It is intended behavior! I found a note in the docs yesterday when I was looking for a solution.
http://aurelia.io/hub.html#/doc/article/aurelia/framework/latest/creating-components/3

I thought I remembered tracking an issue when this was implemented but I couldn't find it. I just found many people reporting this as a bug!

It's definitely something to take note of. It seems to make sense, although I would have expected changed events to not fire on the initial bind in both scenario's.

P.S. This is my first pull request on GitHub! Let me know if I did anything wrong!

@Thanood Thanood merged commit e849c36 into aurelia-ui-toolkits:master Nov 29, 2016
@Thanood
Copy link
Collaborator

Thanood commented Nov 29, 2016

If it's documented, we should be okay. 👍

P.S. This is my first pull request on GitHub!

In that case, congratulations. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants