Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(install): change bridge bundle resources #293

Merged
merged 1 commit into from
Oct 17, 2016

Conversation

Ullfis
Copy link
Contributor

@Ullfis Ullfis commented Oct 5, 2016

Version 0.17.1 added style for chip and range 👍

@Thanood
Copy link
Collaborator

Thanood commented Oct 5, 2016

You're right, thanks! 😃
I've had the feeling that I forgot something important..

I wonder if we can change this somehow so that users don't need to add this. Maybe add these to build resources. At least, that works for webpack.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.154% when pulling 9776468 on Ullfis:aurelia-cli-docs into 99d9fab on aurelia-ui-toolkits:master.

@Ullfis
Copy link
Contributor Author

Ullfis commented Oct 5, 2016

I just tried to change the bridge bundle resources in this project and it worked!

      {
        "name": "materialize-bundle.js",
        "dependencies": [
          "jquery",
          {
            "name": "materialize-css",
            "path": "../node_modules/materialize-css/dist",
            "main": "js/materialize.amd",
            "deps": [
              "jquery"
            ]
          },
          {
            "name": "aurelia-materialize-bridge",
            "path": "../node_modules/aurelia-materialize-bridge/dist/amd",
            "main": "index",
            "deps": [
              "jquery"
            ],
            "resources": [
              "**/*.{css,html}"
            ]
          }
        ]
      }, 

aurelia-cli@0.20.1

Going to test some other projects 😄

@Thanood
Copy link
Collaborator

Thanood commented Oct 5, 2016

Yay! 🎉

@Ullfis
Copy link
Contributor Author

Ullfis commented Oct 5, 2016

Confirming that it works in 2 other aurelia-cli projects.

@Thanood
Copy link
Collaborator

Thanood commented Oct 5, 2016

That did not always work, right?
I hope it stays as it is now. ;-)

@Ullfis
Copy link
Contributor Author

Ullfis commented Oct 5, 2016

It didn't work at all earlier :)

Trying to amend doc changes

@Ullfis Ullfis changed the title docs(install): add chip and range css to requirejs docs(install): change bridge bundle resources Oct 5, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.154% when pulling 8b213f8 on Ullfis:aurelia-cli-docs into 99d9fab on aurelia-ui-toolkits:master.

@Thanood
Copy link
Collaborator

Thanood commented Oct 5, 2016

Thanks!

I'd like to put these docs into a GitBook so that we don't have to update (build, bundle, upload) the app everytime the docs change.

@Thanood
Copy link
Collaborator

Thanood commented Oct 6, 2016

Unhandled rejection Error: src/../scripts/materialize-bundle.html HTTP status: 404

I wonder why it's trying to load that..

@Ullfis
Copy link
Contributor Author

Ullfis commented Oct 6, 2016

Strange. I have not had that error. Latest cli version? Dropped node_modules and reinstalled? Do this project run?

@Thanood
Copy link
Collaborator

Thanood commented Oct 6, 2016

I will try deleting node_modules and reinstall. Did not yet try running your project but copied the aurelia.json.

@Thanood
Copy link
Collaborator

Thanood commented Oct 6, 2016

Your project runs perfectly. 👍
Hmm, I guess I need to compare now.

@Thanood
Copy link
Collaborator

Thanood commented Oct 6, 2016

The first difference seems to be windows path seperators and you're using typescript. 😃
Interesting...

@Thanood
Copy link
Collaborator

Thanood commented Oct 6, 2016

Seems to be some kind of fallback request when anything is not found in the bundle.
I removed the wildcards and put everything back in, then added chips and range css and it worked.. Very strange.

Now, my global aurelia-cli is different from my local one. I'll try upgrading both now.

@Thanood
Copy link
Collaborator

Thanood commented Oct 6, 2016

I've noticed the trace stopping at:

Tracing aurelia-materialize-bridge/collection/collection-item...

With your project it traces all exports.

@Ullfis
Copy link
Contributor Author

Ullfis commented Oct 6, 2016

Very strange. I cant think why it should be different. I will try an esnext cli project later.

@Thanood
Copy link
Collaborator

Thanood commented Oct 6, 2016

I'll try and generate a new project after upgrading everything.

@Thanood
Copy link
Collaborator

Thanood commented Oct 6, 2016

Okay, I'm giving up for today..
Does this project run for you?

I must be overlooking something..

@Thanood
Copy link
Collaborator

Thanood commented Oct 6, 2016

aurelia/webpack-plugin#11

Also, only typescript type (option 2) with the command "au new" works. First default option does not.

I don't know if that's true but if it is, that may be a reason (and everybody else in the world would create TS projects 😂 ).

@Ullfis
Copy link
Contributor Author

Ullfis commented Oct 7, 2016

esnext

...
Tracing aurelia-materialize-bridge/click-counter...
Tracing aurelia-materialize-bridge/breadcrumbs/breadcrumbs...
Tracing aurelia-materialize-bridge/breadcrumbs/breadcrumbs...
Tracing aurelia-materialize-bridge/card/card...
Tracing aurelia-materialize-bridge/card/card...
Tracing aurelia-materialize-bridge/carousel/carousel...
Tracing aurelia-materialize-bridge/carousel/carousel-item...
Tracing aurelia-materialize-bridge...
Tracing text...
...

and so on. It compiled and I could start browser but missed components, so page wouldn't load.

I had to add all resources before it worked. One interesting thing.. I forgot to set stub to false (after adding all components) and it worked anyway. I did not add aurelia-validation on this test.

Project: https://github.com/Ullfis/cli-esnext

@Thanood
Copy link
Collaborator

Thanood commented Oct 7, 2016

I've noticed that, too as you know..
This also happened with a TypeScript project. So, validation..?

@JeroenVinke mentioned an issue where he found out that matching all resources timed out. That would fit the "randomness" of this problem.

@JeroenVinke
Copy link
Member

I have created aurelia/cli#368

@Ullfis
Copy link
Contributor Author

Ullfis commented Oct 8, 2016

I changed build script on the typescript project so it clean the output folder and copy scripts during first build. After that I had to add back bridge resources to make the project run.

Build time related?

@Thanood
Copy link
Collaborator

Thanood commented Oct 9, 2016

It works for me with the changes from Jeroen's PR here:
aurelia/cli#369

@Ullfis
Copy link
Contributor Author

Ullfis commented Oct 9, 2016

Works for me 2. Both typescript and esnext cli project.

@Thanood
Copy link
Collaborator

Thanood commented Oct 10, 2016

Great!
I will wait for the PR being merged. In the meantime I moved the installation instructions to GitBook docs:
https://aurelia-ui-toolkits.gitbooks.io/materialize-bridge-docs/content/installation/aurelia-cli.html

These instructions include chip and range.
Will update the app when I come home in a few hours.

I'll try to host these docs in a GitHub repo to be able to receive documentation PRs.

@Thanood
Copy link
Collaborator

Thanood commented Oct 17, 2016

0.21.0 is out with the fix 🎉

@Thanood Thanood merged commit 7398e16 into aurelia-ui-toolkits:master Oct 17, 2016
@Ullfis Ullfis deleted the aurelia-cli-docs branch October 19, 2016 04:18
@DarienFord
Copy link

So strange; I'm having the same
Unhandled rejection Error: src/../scripts/materialize-bundle.html HTTP status: 404 but in 0.24.0

@Thanood
Copy link
Collaborator

Thanood commented Jan 10, 2017

@DarienFord This is usually a follow-up error, I've seen it frequently when files are missing from the bundle. There should be another error message with the "real" error. Could you check that and post the error if I'm right? 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants