-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(install): change bridge bundle resources #293
Conversation
You're right, thanks! 😃 I wonder if we can change this somehow so that users don't need to add this. Maybe add these to build resources. At least, that works for webpack. |
I just tried to change the bridge bundle resources in this project and it worked! {
"name": "materialize-bundle.js",
"dependencies": [
"jquery",
{
"name": "materialize-css",
"path": "../node_modules/materialize-css/dist",
"main": "js/materialize.amd",
"deps": [
"jquery"
]
},
{
"name": "aurelia-materialize-bridge",
"path": "../node_modules/aurelia-materialize-bridge/dist/amd",
"main": "index",
"deps": [
"jquery"
],
"resources": [
"**/*.{css,html}"
]
}
]
},
aurelia-cli@0.20.1 Going to test some other projects 😄 |
Yay! 🎉 |
Confirming that it works in 2 other aurelia-cli projects. |
That did not always work, right? |
9776468
to
8b213f8
Compare
It didn't work at all earlier :) Trying to amend doc changes |
Thanks! I'd like to put these docs into a GitBook so that we don't have to update (build, bundle, upload) the app everytime the docs change. |
I wonder why it's trying to load that.. |
Strange. I have not had that error. Latest cli version? Dropped node_modules and reinstalled? Do this project run? |
I will try deleting node_modules and reinstall. Did not yet try running your project but copied the |
Your project runs perfectly. 👍 |
The first difference seems to be windows path seperators and you're using typescript. 😃 |
Seems to be some kind of fallback request when anything is not found in the bundle. Now, my global aurelia-cli is different from my local one. I'll try upgrading both now. |
I've noticed the trace stopping at:
With your project it traces all exports. |
Very strange. I cant think why it should be different. I will try an esnext cli project later. |
I'll try and generate a new project after upgrading everything. |
Okay, I'm giving up for today.. I must be overlooking something.. |
I don't know if that's true but if it is, that may be a reason (and everybody else in the world would create TS projects 😂 ). |
esnext...
Tracing aurelia-materialize-bridge/click-counter...
Tracing aurelia-materialize-bridge/breadcrumbs/breadcrumbs...
Tracing aurelia-materialize-bridge/breadcrumbs/breadcrumbs...
Tracing aurelia-materialize-bridge/card/card...
Tracing aurelia-materialize-bridge/card/card...
Tracing aurelia-materialize-bridge/carousel/carousel...
Tracing aurelia-materialize-bridge/carousel/carousel-item...
Tracing aurelia-materialize-bridge...
Tracing text...
... and so on. It compiled and I could start browser but missed components, so page wouldn't load. I had to add all resources before it worked. One interesting thing.. I forgot to set stub to false (after adding all components) and it worked anyway. I did not add aurelia-validation on this test. Project: https://github.com/Ullfis/cli-esnext |
I've noticed that, too as you know.. @JeroenVinke mentioned an issue where he found out that matching all resources timed out. That would fit the "randomness" of this problem. |
I have created aurelia/cli#368 |
I changed build script on the typescript project so it clean the output folder and copy scripts during first build. After that I had to add back bridge resources to make the project run. Build time related? |
It works for me with the changes from Jeroen's PR here: |
Works for me 2. Both typescript and esnext cli project. |
Great! These instructions include chip and range. I'll try to host these docs in a GitHub repo to be able to receive documentation PRs. |
0.21.0 is out with the fix 🎉 |
So strange; I'm having the same |
@DarienFord This is usually a follow-up error, I've seen it frequently when files are missing from the bundle. There should be another error message with the "real" error. Could you check that and post the error if I'm right? 😃 |
Version 0.17.1 added style for chip and range 👍